Messages in this thread | | | Date | Tue, 14 Jan 2020 12:07:59 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] USB: serial: opticon: fix control-message timeouts |
| |
On Mon, Jan 13, 2020 at 07:25:46PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 13, 2020 at 06:22:13PM +0100, Johan Hovold wrote: > > The driver was issuing synchronous uninterruptible control requests > > without using a timeout. This could lead to the driver hanging > > on open() or tiocmset() due to a malfunctioning (or malicious) device > > until the device is physically disconnected. > > > > The USB upper limit of five seconds per request should be more than > > enough. > > > > Fixes: 309a057932ab ("USB: opticon: add rts and cts support") > > Cc: stable <stable@vger.kernel.org> # 2.6.39 > > Cc: Martin Jansen <martin.jansen@opticon.com> > > Signed-off-by: Johan Hovold <johan@kernel.org> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for reviewing these. This one; now applied.
Johan
| |