Messages in this thread | | | From | "Pandruvada, Srinivas" <> | Subject | Re: [PATCH v2 1/2] platform/x86: Add support for Uncore frequency control | Date | Mon, 13 Jan 2020 18:03:02 +0000 |
| |
Hi Chenyu,
Thanks for the pointing.
On Mon, 2020-01-13 at 15:00 +0800, Yu Chen wrote: > Hi Srinivas, > On Mon, Jan 13, 2020 at 11:59 AM Srinivas Pandruvada > <srinivas.pandruvada@linux.intel.com> wrote: > > + > > +/* Common function to set min/max ratios to be used by sysfs > > callbacks */ > > +static int uncore_write_ratio(struct uncore_data *data, unsigned > > int input, > > + int set_max) > > +{ > > + int ret; > > + u64 cap; > > + > > + mutex_lock(&uncore_lock); > > + > > + input /= UNCORE_FREQ_KHZ_MULTIPLIER; > > + if (!input || input > 0x7F) { > > + ret = -EINVAL; > > + goto finish_write; > > + } > > + > > + rdmsrl(MSR_UNCORE_RATIO_LIMIT, cap); > Should it be rdmsrl_on_cpu()? Yes. Fixed and sent update.
Thanks, Srinivas
> > Thanks, > Chenyu
| |