lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v5 02/15] net: macsec: introduce the macsec_context structure
On Mon, Jan 13, 2020 at 03:39:56PM +0100, Jiri Pirko wrote:
> Fri, Jan 10, 2020 at 05:19:57PM CET, antoine.tenart@bootlin.com wrote:
>
> >diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> >index 1d69f637c5d6..024af2d1d0af 100644
> >--- a/include/uapi/linux/if_link.h
> >+++ b/include/uapi/linux/if_link.h
> >@@ -486,6 +486,13 @@ enum macsec_validation_type {
> > MACSEC_VALIDATE_MAX = __MACSEC_VALIDATE_END - 1,
> > };
> >
> >+enum macsec_offload {
> >+ MACSEC_OFFLOAD_OFF = 0,
> >+ MACSEC_OFFLOAD_PHY = 1,
>
> No need to assign 0, 1 here. That is given.

Right, however MACSEC_VALIDATE_ uses the same notation. I think it's
nice to be consistent, but of course of patch can be sent to convert
both of those enums.

> >+ __MACSEC_OFFLOAD_END,
> >+ MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,
> >+};
> >+
> > /* IPVLAN section */
> > enum {
> > IFLA_IPVLAN_UNSPEC,
> >diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h
> >index 8aec8769d944..42efdb84d189 100644
> >--- a/tools/include/uapi/linux/if_link.h
> >+++ b/tools/include/uapi/linux/if_link.h
>
> Why you are adding to this header?

Because the two headers are synced.

Thanks,
Antoine

--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2020-01-13 16:13    [W:0.101 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site