Messages in this thread | | | Date | Mon, 13 Jan 2020 14:41:01 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] dt-bindings: vqmmc-ipq4019-regulator: add binding document |
| |
On Sun, Jan 12, 2020 at 12:30:02PM +0100, Robert Marko wrote:
> + regulator-min-microvolt: > + description: smallest voltage consumers may set > + > + regulator-max-microvolt: > + description: largest voltage consumers may set
Why are these explicitly specified in this binding?
> + regulator-always-on: > + description: boolean, regulator should never be disabled > + type: boolean
If it's not physically possible to disable the regulator then specifying this property is redundant so...
> +required: > + - compatible > + - reg > + - regulator-name > + - regulator-min-microvolt > + - regulator-max-microvolt > + - regulator-always-on
...requiring it doesn't seem useful. All the other regulator-specific properties shouldn't be required either, unless the user specifies a voltage range we won't allow changes at all which should be safe and the name is purely cosmetic. [unhandled content-type:application/pgp-signature] | |