Messages in this thread | | | From | Wambui Karuga <> | Date | Mon, 13 Jan 2020 16:17:11 +0300 (EAT) | Subject | Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. |
| |
On Mon, 13 Jan 2020, Jani Nikula wrote:
> On Mon, 13 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote: >> Quoting Wambui Karuga (2020-01-13 11:10:25) >>> fn(...) { >>> ... >>> struct intel_engine_cs *E = ...; >>> +struct drm_i915_private *dev_priv = E->i915; >> >> No new dev_priv. > > Wambui, we're gradually converting all dev_priv variable and parameter > names to i915. > Okay, I can change to that - dev_priv seemed more used in the files I changed.
Thanks, wambui >> There should be no reason for drm_dbg here, as the rest of the debug is >> behind ENGINE_TRACE and so the vestigial debug should be moved over, or >> deleted as not being useful. >> >> The error messages look unhelpful. > > I don't think you can expect any meaninful improvements on the debug > message contents from Wambui without detailed help at this point. > >> >>> if ((batch_end - cmd) < length) { >>> - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", >>> - *cmd, >>> - length, >>> - batch_end - cmd); >>> + drm_dbg(&dev_priv->drm, >>> + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", >> >> No. This is not driver debug. If anything this should be pr_debug, or >> some over user centric channel. > > I'm sorry, I still don't understand your reasoning here. > > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Graphics Center >
| |