Messages in this thread | | | Subject | Re: [PATCH] arm64: dts: rockchip: add reg property to brcmf sub node | From | Robin Murphy <> | Date | Mon, 13 Jan 2020 10:27:12 +0000 |
| |
On 13/01/2020 9:26 am, Heiko Stuebner wrote: > Hi Johan, > > Am Freitag, 10. Januar 2020, 16:40:24 CET schrieb Johan Jonker: >> Hi, >> >> Question for Heiko or rob+dt. >> Where would should #address-cells and #size-cells go in the dts or to the dtsi. >> In case they become required in a futhure rockchip-dw-mshc.yaml? >> ie. Should we patch all XXX rockchip,rk3288-dw-mshc nodes with them? > > I don't think it is a required property for the dw-mmc itself, as only > in special-cases do you need subnodes there. Like emmc and sd-cards > are completely probeable without needing further information and > only the wifi/bt chips _might_ need these. > > So I don't think that this is a property of the controller itself, but te > connected card - hence should stay in the board file.
Indeed, and in general dtc already warns about those properties being present unnecessarily, e.g.:
arch/arm64/boot/dts/rockchip/rk3399.dtsi:1812.27-1847.4: Warning (avoid_unnecessary_addr_size): /mipi@ff968000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Robin.
| |