Messages in this thread | | | From | Prashant Malani <> | Date | Mon, 13 Jan 2020 18:42:42 -0800 | Subject | Re: [PATCH v4 1/2] platform: chrome: Add cros-usbpd-notify driver |
| |
Hi Enric,
> > Perhaps we should just make them two separate ifdef blocks, i.e #ifdef > > CONFIG_OF, and then #ifdef CONFIG_ACPI? Would be great to hear your > > recommendation here. > > > > If understand correctly what you want is on some devices (usually the ones that > use ACPI to instantiate the devices) use the notify ACPI callback, otherwise, on > devices using OF to instantiate the devices, create a notifier. The driver > should work on both cases. The problem is that CONFIG_OF and CONFIG_ACPI are not > exclusive and select one does not imply not select the other. So yes I'm fine > on have both ifdef blocks, but in the cros_ec_dev (patch 2/2) you should > register the notifier only if IS_ENABLED(CONFIG_OF) > Thanks. Will upload the updated patches soon.
Best regards, > Cheers, > Enric > > > Thanks again! > >
| |