Messages in this thread | | | From | Andrei Vagin <> | Date | Sun, 12 Jan 2020 21:27:31 -0800 | Subject | Re: [PATCHv8 02/34] lib/vdso: make do_hres and do_coarse as __always_inline |
| |
On Fri, Jan 10, 2020 at 4:02 AM Thomas Gleixner <tglx@linutronix.de> wrote: > > Vincenzo Frascino <vincenzo.frascino@arm.com> writes: > > On 1/10/20 11:42 AM, Thomas Gleixner wrote: > >>>> +» » /*·goto·allows·to·avoid·extra·inlining·of·do_hres.·*/ > >>>> +» » goto·out_hres; > >>> > >>> What is the performance impact of "goto out_hres"? > >> > >> On x86 it's invisible at least in my limited testing. > > > > On arm64 as well based on mine as well. Shall we keep the code more readable > > here (without goto)? > > The delta patch below makes it readable again and also avoids the double > inlining. Quick testing shows no difference.
My tests show no difference too and the code looks more readable. Thanks!
> > Thanks, > > tglx
| |