lkml.org 
[lkml]   [2020]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 40/91] media: flexcop-usb: ensure -EIO is returned on error condition
    Date
    From: Colin Ian King <colin.king@canonical.com>

    commit 74a96b51a36de4d86660fbc56b05d86668162d6b upstream.

    An earlier commit hard coded a return 0 to function flexcop_usb_i2c_req
    even though the an -EIO was intended to be returned in the case where
    ret != buflen. Fix this by replacing the return 0 with the return of
    ret to return the error return code.

    Addresses-Coverity: ("Unused value")

    Fixes: b430eaba0be5 ("[media] flexcop-usb: don't use stack for DMA")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/b2c2/flexcop-usb.c
    +++ b/drivers/media/usb/b2c2/flexcop-usb.c
    @@ -295,7 +295,7 @@ static int flexcop_usb_i2c_req(struct fl

    mutex_unlock(&fc_usb->data_mutex);

    - return 0;
    + return ret;
    }

    /* actual bus specific access functions,

    \
     
     \ /
      Last update: 2020-01-11 11:02    [W:4.050 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site