lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 RFT] media: exynos4-is: add missed clk_disable_unprepare in remove
    From
    Date
    Anyone able/willing to test this patch?

    Regards,

    Hans

    On 12/19/19 8:48 AM, Chuhong Yuan wrote:
    > This driver forgets to disable and unprepare clock when remove.
    > Add a call to clk_disable_unprepare() to fix it.
    >
    > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    > ---
    > Changes in v2:
    > - Add a check of pm_runtime_enable() to match enable in probe.
    > - Add RFT tag.
    >
    > drivers/media/platform/exynos4-is/fimc-lite.c | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c
    > index e87c6a09205b..17de14fbba31 100644
    > --- a/drivers/media/platform/exynos4-is/fimc-lite.c
    > +++ b/drivers/media/platform/exynos4-is/fimc-lite.c
    > @@ -1614,6 +1614,9 @@ static int fimc_lite_remove(struct platform_device *pdev)
    > struct fimc_lite *fimc = platform_get_drvdata(pdev);
    > struct device *dev = &pdev->dev;
    >
    > + if (!pm_runtime_enabled(dev))
    > + clk_disable_unprepare(fimc->clock);
    > +
    > pm_runtime_disable(dev);
    > pm_runtime_set_suspended(dev);
    > fimc_lite_unregister_capture_subdev(fimc);
    >

    \
     
     \ /
      Last update: 2020-01-10 14:41    [W:5.902 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site