Messages in this thread | | | From | Enric Balletbo i Serra <> | Subject | Re: [PATCH] platform/chrome: wilco_ec: Fix keyboard backlight probing | Date | Fri, 10 Jan 2020 11:46:08 +0100 |
| |
Hi Daniel, On 8/1/20 16:59, Daniel Campello wrote: > Hi Enric, > > On Wed, Jan 08, 2020 at 11:38:58AM +0100, Enric Balletbo i Serra wrote: >> Hi Daniel, >> >> Many thanks for sending the patch upstream. >> >> On 7/1/20 19:24, Daniel Campello wrote: >>> The EC on the Wilco platform responds with 0xFF to commands related to >>> the keyboard backlight on the absence of a keyboard backlight module. >>> This change allows the EC driver to continue loading even if the >>> backlight module is not present. >>> >> >> Could you explain a bit more which is the problem you're trying to solve? I am >> not sure I understand it, isn't the kbbl_exist call for that purpose? (in >> absence of the keyboard backligh module just don't init the device?) > > kbbl_exists is intended to return a bool based on response.status != > 0xFF. Without this patch kbbl_exists will fail and return an -EIO > error on any value of response.status >
Thanks for the explanation I understand now what is happening. I added the Fixed tag and queued as a fix for chrome-platform-5.5
Thanks, Enric
>> >> Thanks, >> Enric >>
| |