Messages in this thread | | | From | Arvind Sankar <> | Date | Wed, 1 Jan 2020 13:32:44 -0500 | Subject | Re: [PATCH] early init: open /dev/console with O_LARGEFILE |
| |
On Tue, Dec 31, 2019 at 07:30:19PM -0500, Arvind Sankar wrote: > On Tue, Dec 31, 2019 at 04:02:26PM +0100, Dominik Brodowski wrote: > > If force_o_largefile() is true, /dev/console used to be opened > > with O_LARGEFILE. Retain that behaviour. > > > > One other thing that used to happen is fsnotify_open() -- I don't know > how that might affect this, but it seems like the only thing left that's > different.
Also, this shouldn't impact the current issue I think, but won't doing filp_open followed by 3 f_dupfd's cause the file->f_count to become 4 but with only 3 open fd's? Don't we have to do an fd_install for the first one and only 2 f_dupfd's?
| |