Messages in this thread | | | Date | Tue, 10 Sep 2019 01:35:56 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again |
| |
Hi Arnd,
Thank you for the patch.
On Mon, Sep 09, 2019 at 10:33:57PM +0200, Arnd Bergmann wrote: > This was apparently dropped by accident in a recent > cleanup, causing a build failure in some configurations now: > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration] > > Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index 525dc1c0f1c1..9edcdd7f2b96 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -8,6 +8,7 @@ > #include <linux/mod_devicetable.h> > #include <linux/of_gpio.h> > #include <linux/platform_device.h> > +#include <linux/pinctrl/consumer.h>
I'd put this before platform_device.h to keep the headers alphabetically ordered. Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> #include <drm/drm_atomic_helper.h> > #include <drm/drm_encoder.h>
-- Regards,
Laurent Pinchart
| |