Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 9 Sep 2019 15:34:07 -0700 | Subject | Re: [PATCH v2 06/11] mmc: core: Clarify that the ->ack_sdio_irq() callback is mandatory |
| |
Hi,
On Sun, Sep 8, 2019 at 3:12 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > For the MMC_CAP2_SDIO_IRQ_NOTHREAD case and when using sdio_signal_irq(), > the ->ack_sdio_irq() is already mandatory, which was not the case for those > host drivers that called sdio_run_irqs() directly. > > As there are no longer any drivers calling sdio_run_irqs(), let's clarify > the code by dropping the unnecessary check and explicitly state that the > callback is mandatory in the header file. > > Tested-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/mmc/core/sdio_irq.c | 3 +-- > include/linux/mmc/host.h | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |