Messages in this thread | | | Subject | Re: [PATCH 2/9] thunderbolt: show key using %*s not %*pE | From | Joe Perches <> | Date | Mon, 09 Sep 2019 12:34:42 -0700 |
| |
On Thu, 2019-09-05 at 15:44 -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" <bfields@redhat.com> > > %*pEp (without "h" or "o") is a no-op. This string could contain > arbitrary (non-NULL) characters, so we do want escaping. Use %*pE like > every other caller. [] > diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c [] > @@ -636,7 +636,7 @@ static ssize_t key_show(struct device *dev, struct device_attribute *attr, > * It should be null terminated but anything else is pretty much > * allowed. > */ > - return sprintf(buf, "%*pEp\n", (int)strlen(svc->key), svc->key); > + return sprintf(buf, "%*pE\n", (int)strlen(svc->key), svc->key);
The code does not match the patch subject / commit title.
| |