Messages in this thread | | | Date | Mon, 9 Sep 2019 17:31:37 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH v3 08/10] EDAC/amd64: Gather hardware information early |
| |
On Fri, Sep 06, 2019 at 08:49:52PM +0000, Ghannam, Yazen wrote: > All the fields are register values, and there are unique instances for > each channel. They can potentially all be different.
Hmm, ok, that's 160 bytes more per node. And on !Rome it is wasted. Oh well, let's remain conservative then and allocate it only where needed.
Btw, upon a second look, compute_num_umcs() can be made part of get_hardware_info() instead of having this as a separate function which gets called only once before probe_one_instance().
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |