Messages in this thread Patch in this message | | | From | Sudeep Holla <> | Subject | [PATCH -next] reset: reset-scmi: add missing handle initialisation | Date | Mon, 9 Sep 2019 16:21:07 +0100 |
| |
scmi_reset_data->handle needs to be initialised at probe, so that it can be used to access scmi reset protocol apis using the same later.
Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue.
Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI") Cc: Philipp Zabel <p.zabel@pengutronix.de> Reported-by: Etienne Carriere <etienne.carriere@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/reset/reset-scmi.c | 1 + 1 file changed, 1 insertion(+)
Hi Philipp,
I can either take this via ARM SoC as the driver is getting merged through ARM SoC tree, or you can apply this once it gets landed in mainline. I am fine with whatever you prefer.
Regards, Sudeep
diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c index c6d3c8427f14..b46df80ec6c3 100644 --- a/drivers/reset/reset-scmi.c +++ b/drivers/reset/reset-scmi.c @@ -102,6 +102,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) data->rcdev.owner = THIS_MODULE; data->rcdev.of_node = np; data->rcdev.nr_resets = handle->reset_ops->num_domains_get(handle); + data->handle = handle;
return devm_reset_controller_register(dev, &data->rcdev); } -- 2.17.1
| |