Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 9 Sep 2019 15:45:18 +0200 | Subject | Re: [PATCH 3/3] arm64: alpine: select AL_POS |
| |
On Mon, Sep 9, 2019 at 12:17 PM Shenhar, Talel <talel@amazon.com> wrote: > On 9/9/2019 12:40 PM, Arnd Bergmann wrote: > > On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar <talel@amazon.com> wrote: > >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > >> index 4778c77..bd86b15 100644 > >> --- a/arch/arm64/Kconfig.platforms > >> +++ b/arch/arm64/Kconfig.platforms > >> @@ -25,6 +25,7 @@ config ARCH_SUNXI > >> config ARCH_ALPINE > >> bool "Annapurna Labs Alpine platform" > >> select ALPINE_MSI if PCI > >> + select AL_POS > >> help > >> This enables support for the Annapurna Labs Alpine > >> Soc family. > > Generally I think this kind of thing should go into the defconfig > > rather than being hard-selected. There might be users that > > want to not enable the driver. > > The reason for selecting it is because this is a driver that we will > always want for ARCH_ALPINE.
Can you put the exact requirement (other than "we want this") in the changelog text then? It's still not clear to me what breaks without this driver.
Arnd
| |