Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 9 Sep 2019 15:43:29 +0200 | Subject | Re: [PATCH 2/2] export.h, genksyms: do not make genksyms calculate CRC of trimmed symbols |
| |
On Mon, Sep 9, 2019 at 12:53 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Since commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* > functions"), it is harmful because the bogus __crc* symbols make > modpost call sym_update_crc(), and then new_symbol(), but there is > no one that clears the ->is_static member. > > I gave Fixes to the first commit that uncovered the issue, but the > potential problem has long existed since commit f235541699bc > ("export.h: allow for per-symbol configurable EXPORT_SYMBOL()"). > > Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions") > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Arnd Bergmann <arnd@arndb.de>
Thanks for providing a proper fix!
Arnd
| |