Messages in this thread | | | Date | Mon, 9 Sep 2019 11:59:42 +0100 | From | Daniel Thompson <> | Subject | Re: [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios |
| |
On Sun, Sep 08, 2019 at 10:37:04PM +0200, Andreas Kemnade wrote: > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Looks like patches are in the wrong order. Changes to bindings must appear in patchsets *before* the Linux implementation of the bindings.
> --- > .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..a9656d72b668 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg
Please add enable-gpios to one of the examples.
Daniel.
| |