Messages in this thread Patch in this message | | | Date | Mon, 9 Sep 2019 12:41:55 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v2 3/3] media: Add support for Cadence CSI2RX 2.1 |
| |
Hi Jan,
On Mon, Sep 09, 2019 at 09:24:15AM +0000, Jan Kotas wrote: > >> @@ -439,6 +535,9 @@ static int csi2rx_probe(struct platform_device *pdev) > >> csi2rx->dev = &pdev->dev; > >> mutex_init(&csi2rx->lock); > >> > >> + of_id = of_match_node(csi2rx_of_table, pdev->dev.of_node); > >> + csi2rx->vops = (struct csi2rx_vops *)of_id->data; > > > > The cast isn't needed, is it? > > It’s not, but doesn’t make it more readable?
If there's no need for it, please don't use explicit cast.
-- Sakari Ailus
| |