Messages in this thread | | | Date | Mon, 9 Sep 2019 12:22:11 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] [v2] pinctrl: intel: mark intel_pin_to_gpio __maybe_unused |
| |
On Fri, Sep 06, 2019 at 08:51:59PM +0200, Arnd Bergmann wrote: > The intel_pin_to_gpio() function is only called by the > PM support functions and causes a warning when those are disabled: > > drivers/pinctrl/intel/pinctrl-intel.c:841:12: error: unused function 'intel_pin_to_gpio' [-Werror,-Wunused-function] > > Mark it __maybe_unused to suppress the warning. >
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v2: use __maybe_unused instead of moving the code > --- > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c > index d66fe2b4221b..1f13bcd0e4e1 100644 > --- a/drivers/pinctrl/intel/pinctrl-intel.c > +++ b/drivers/pinctrl/intel/pinctrl-intel.c > @@ -838,7 +838,7 @@ static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, unsigned int offset, > * > * Translate the pin number of pinctrl to GPIO offset > */ > -static int intel_pin_to_gpio(struct intel_pinctrl *pctrl, int pin) > +static __maybe_unused int intel_pin_to_gpio(struct intel_pinctrl *pctrl, int pin) > { > const struct intel_community *community; > const struct intel_padgroup *padgrp; > -- > 2.20.0 >
-- With Best Regards, Andy Shevchenko
| |