Messages in this thread Patch in this message | | | From | Ding Xiang <> | Subject | [PATCH] ovl: Fix dereferencing possible ERR_PTR() | Date | Mon, 9 Sep 2019 16:29:56 +0800 |
| |
if ovl_encode_real_fh() fails, no memory was allocated and the error in the error-valued pointer should be returned.
Fixes: 9b6faee0747 ("ovl: check ERR_PTR() return value from ovl_encode_fh()") Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> --- fs/overlayfs/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/export.c b/fs/overlayfs/export.c index cb8ec1f..50ade19 100644 --- a/fs/overlayfs/export.c +++ b/fs/overlayfs/export.c @@ -229,7 +229,7 @@ static int ovl_d_to_fh(struct dentry *dentry, char *buf, int buflen) ovl_dentry_upper(dentry), !enc_lower); err = PTR_ERR(fh); if (IS_ERR(fh)) - goto fail; + return err; err = -EOVERFLOW; if (fh->len > buflen) -- 1.9.1
| |