Messages in this thread | | | Date | Sun, 8 Sep 2019 19:31:49 +0000 | From | Valentin Vidić <> | Subject | Re: [PATCH v3 2/4] staging: exfat: drop duplicate date_time_t struct |
| |
On Sun, Sep 08, 2019 at 07:54:24PM +0100, Greg Kroah-Hartman wrote: > On Sun, Sep 08, 2019 at 05:35:37PM +0000, Valentin Vidic wrote: > > +struct timestamp_t { > > + u16 millisec; /* 0 ~ 999 */ > > You added this field to this structure, why? You did not document that > in the changelog text above. Are you _sure_ you can do this and that > this does not refer to an on-disk layout?
Both date_time_t and timestamp_t were used in memory only, but date_time_t had the additional MilliSecond field. To keep the functionality I added the millisec field to timestamp_t and replaced all usages of date_time_t with timestamp_t.
For storing on disk the values from timestamp_t get shifted and combined (exfat_set_entry_time).
-- Valentin
| |