lkml.org 
[lkml]   [2019]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 20/40] HID: cp2112: prevent sleeping function called from invalid context
    Date
    [ Upstream commit 2d05dba2b25ecb0f8fc3a0b4eb2232da6454a47b ]

    When calling request_threaded_irq() with a CP2112, the function
    cp2112_gpio_irq_startup() is called in a IRQ context.

    Therefore we can not sleep, and we can not call
    cp2112_gpio_direction_input() there.

    Move the call to cp2112_gpio_direction_input() earlier to have a working
    driver.

    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-cp2112.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
    index 4e940a096b2ac..abf1079457664 100644
    --- a/drivers/hid/hid-cp2112.c
    +++ b/drivers/hid/hid-cp2112.c
    @@ -1149,8 +1149,6 @@ static unsigned int cp2112_gpio_irq_startup(struct irq_data *d)

    INIT_DELAYED_WORK(&dev->gpio_poll_worker, cp2112_gpio_poll_callback);

    - cp2112_gpio_direction_input(gc, d->hwirq);
    -
    if (!dev->gpio_poll) {
    dev->gpio_poll = true;
    schedule_delayed_work(&dev->gpio_poll_worker, 0);
    @@ -1198,6 +1196,12 @@ static int __maybe_unused cp2112_allocate_irq(struct cp2112_device *dev,
    return PTR_ERR(dev->desc[pin]);
    }

    + ret = cp2112_gpio_direction_input(&dev->gc, pin);
    + if (ret < 0) {
    + dev_err(dev->gc.parent, "Failed to set GPIO to input dir\n");
    + goto err_desc;
    + }
    +
    ret = gpiochip_lock_as_irq(&dev->gc, pin);
    if (ret) {
    dev_err(dev->gc.parent, "Failed to lock GPIO as interrupt\n");
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-08 15:00    [W:2.135 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site