lkml.org 
[lkml]   [2019]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 19/94] net/rds: Fix info leak in rds6_inc_info_copy()
    Date
    From: Ka-Cheong Poon <ka-cheong.poon@oracle.com>

    [ Upstream commit 7d0a06586b2686ba80c4a2da5f91cb10ffbea736 ]

    The rds6_inc_info_copy() function has a couple struct members which
    are leaking stack information. The ->tos field should hold actual
    information and the ->flags field needs to be zeroed out.

    Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
    Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support")
    Reported-by: 黄ID蝴蝶 <butterflyhuangxx@gmail.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
    Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/rds/recv.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/net/rds/recv.c
    +++ b/net/rds/recv.c
    @@ -1,5 +1,5 @@
    /*
    - * Copyright (c) 2006, 2018 Oracle and/or its affiliates. All rights reserved.
    + * Copyright (c) 2006, 2019 Oracle and/or its affiliates. All rights reserved.
    *
    * This software is available to you under a choice of one of two
    * licenses. You may choose to be licensed under the terms of the GNU
    @@ -811,6 +811,7 @@ void rds6_inc_info_copy(struct rds_incom

    minfo6.seq = be64_to_cpu(inc->i_hdr.h_sequence);
    minfo6.len = be32_to_cpu(inc->i_hdr.h_len);
    + minfo6.tos = inc->i_conn->c_tos;

    if (flip) {
    minfo6.laddr = *daddr;
    @@ -824,6 +825,8 @@ void rds6_inc_info_copy(struct rds_incom
    minfo6.fport = inc->i_hdr.h_dport;
    }

    + minfo6.flags = 0;
    +
    rds_info_copy(iter, &minfo6, sizeof(minfo6));
    }
    #endif

    \
     
     \ /
      Last update: 2019-09-08 14:57    [W:4.169 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site