lkml.org 
[lkml]   [2019]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 18/57] Bluetooth: btqca: Add a short delay before downloading the NVM
    Date
    [ Upstream commit 8059ba0bd0e4694e51c2ee6438a77b325f06c0d5 ]

    On WCN3990 downloading the NVM sometimes fails with a "TLV response
    size mismatch" error:

    [ 174.949955] Bluetooth: btqca.c:qca_download_firmware() hci0: QCA Downloading qca/crnv21.bin
    [ 174.958718] Bluetooth: btqca.c:qca_tlv_send_segment() hci0: QCA TLV response size mismatch

    It seems the controller needs a short time after downloading the
    firmware before it is ready for the NVM. A delay as short as 1 ms
    seems sufficient, make it 10 ms just in case. No event is received
    during the delay, hence we don't just silently drop an extra event.

    Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bluetooth/btqca.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
    index ec9e03a6b7786..9e70f7c7e5659 100644
    --- a/drivers/bluetooth/btqca.c
    +++ b/drivers/bluetooth/btqca.c
    @@ -363,6 +363,9 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
    return err;
    }

    + /* Give the controller some time to get ready to receive the NVM */
    + msleep(10);
    +
    /* Download NVM configuration */
    config.type = TLV_TYPE_NVM;
    if (soc_type == QCA_WCN3990)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-08 14:48    [W:2.601 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site