Messages in this thread | | | Subject | Re: [PATCHv2] nvme: Assign subsy instance from first ctrl | From | Minwoo Im <> | Date | Sat, 07 Sep 2019 15:13:49 +0900 |
| |
> Subject: [PATCHv2] nvme: Assign subsy instance from first ctrl
I'm not sure but, I have not seen 'subsy' thing before. Maybe s/sybsy/subsys/ ?
> > The namespace disk names must be unique for the lifetime of the > subsystem. This was accomplished by using their parent subsystems' > instances which were allocated independently from the controllers > connected to that subsystem. This allowed name prefixes assigned to > namespaces to match a controller from an unrelated subsystem, and has > created confusion among users examining device nodes. > > Ensure a namespace's subsystem instance never clashes with a controller > instance of another subsystem by transferring the instance ownership > to the parent subsystem from the first controller discovered in that > subsystem. > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > Signed-off-by: Keith Busch <kbusch@kernel.org>
Keith, Thanks for this patch. I really like this concept which can avoid from instance mistakes.
Otherwise looks good to me.
Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
| |