Messages in this thread Patch in this message | | | Date | Sat, 7 Sep 2019 07:59:17 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] Add PCI device IDs for family 17h, model 70h |
| |
On Fri, Sep 06, 2019 at 11:21:38PM +0000, Isaac Vaughn wrote: > Add the new Family 17h Model 70h PCI IDs (device 18h functions 0 and 6) > to the AMD64 EDAC module. > > Cc: Borislav Petkov <bp@alien8.de> (maintainer:EDAC-AMD64) > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (supporter:EDAC-CORE) > Cc: James Morse <james.morse@arm.com> (reviewer:EDAC-CORE) > Cc: linux-edac@vger.kernel.org (open list:EDAC-AMD64) > Cc: linux-kernel@vger.kernel.org (open list) > Signed-off-by: Isaac Vaughn <isaac.vaughn@knights.ucf.edu> > --- > drivers/edac/amd64_edac.c | 13 +++++++++++++ > drivers/edac/amd64_edac.h | 3 +++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c > index 873437be86d9..a35c97f9100a 100644 > --- a/drivers/edac/amd64_edac.c > +++ b/drivers/edac/amd64_edac.c > @@ -2253,6 +2253,15 @@ static struct amd64_family_type family_types[] = { > .dbam_to_cs = f17_base_addr_to_cs_size, > } > }, > + [F17_M70H_CPUS] = { > + .ctl_name = "F17h_M70h", > + .f0_id = PCI_DEVICE_ID_AMD_17H_M70H_DF_F0, > + .f6_id = PCI_DEVICE_ID_AMD_17H_M70H_DF_F6, > + .ops = { > + .early_channel_count = f17_early_channel_count, > + .dbam_to_cs = f17_base_addr_to_cs_size,
You still have f17_base_addr_to_cs_size here. If you'd built it against the branch I pointed you at:
https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-for-next
it would have failed.
Anyway, I fixed it up and applied it.
Thx.
-- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
| |