lkml.org 
[lkml]   [2019]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] net: phy: dp83867: Add documentation for SGMII mode type
    On Thu, Sep 05, 2019 at 07:26:00PM +0300, Vitaly Gaiduk wrote:
    > Add documentation of ti,sgmii-type which can be used to select
    > SGMII mode type (4 or 6-wire).
    >
    > Signed-off-by: Vitaly Gaiduk <vitaly.gaiduk@cloudbear.ru>
    > ---
    > Documentation/devicetree/bindings/net/ti,dp83867.txt | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt
    > index db6aa3f2215b..18e7fd52897f 100644
    > --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
    > +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
    > @@ -37,6 +37,7 @@ Optional property:
    > for applicable values. The CLK_OUT pin can also
    > be disabled by this property. When omitted, the
    > PHY's default will be left as is.
    > + - ti,sgmii-type - This denotes the fact which SGMII mode is used (4 or 6-wire).

    Hi Vitaly

    You probably want to make this a Boolean. I don't think SGMII type is
    a good idea. This is about enabling the receive clock to be passed to
    the MAC. So how about ti,sgmii-ref-clock-output-enable.

    Andrew

    \
     
     \ /
      Last update: 2019-09-07 17:41    [W:4.223 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site