Messages in this thread | | | Date | Fri, 6 Sep 2019 11:31:47 -0400 | From | "Theodore Y. Ts'o" <> | Subject | Re: [PATCH] unicode: make array 'token' static const, makes object smaller |
| |
On Fri, Sep 06, 2019 at 02:58:07PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the array 'token' on the stack but instead make it > static const. Makes the object code smaller by 234 bytes. > > Before: > text data bss dec hex filename > 5371 272 0 5643 160b fs/unicode/utf8-core.o > > After: > text data bss dec hex filename > 5041 368 0 5409 1521 fs/unicode/utf8-core.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Nice, thanks!
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
| |