| Date | Fri, 6 Sep 2019 13:06:57 +0100 | From | Stefan Hajnoczi <> | Subject | Re: [PATCH 18/18] virtiofs: Remove TODO item from virtio_fs_free_devs() |
| |
On Thu, Sep 05, 2019 at 03:48:59PM -0400, Vivek Goyal wrote: > virtio_fs_free_devs() is now called from ->kill_sb(). By this time > all device queues have been quiesced. I am assuming that while > ->kill_sb() is in progress, another mount instance will wait for > it to finish (sb->s_umount mutex provides mutual exclusion). > > W.r.t ->remove path, we should be fine as we are not touching vdev > or virtqueues. And we have reference on virtio_fs object, so we know > rest of the data structures are valid. > > So I can't see the need of any additional locking yet. > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [unhandled content-type:application/pgp-signature] |