Messages in this thread | | | Date | Fri, 6 Sep 2019 14:11:17 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message |
| |
On Fri, Sep 06, 2019 at 02:06:44PM +0300, Dan Elkouby wrote: > hidp_send_message was changed to return non-zero values on success, > which some other bits did not expect. This caused spurious errors to be > propagated through the stack, breaking some drivers, such as hid-sony > for the Dualshock 4 in Bluetooth mode. > > As pointed out by Dan Carpenter, hid-microsoft directly relied on that > assumption as well. > > Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes") > > Signed-off-by: Dan Elkouby <streetwalkermc@gmail.com>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |