Messages in this thread | | | Date | Thu, 5 Sep 2019 11:57:08 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH 09/11] mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq() |
| |
On Tue, Sep 03, 2019 at 04:22:05PM +0200, Ulf Hansson wrote: > The sdhci_ack_sdio_irq() is called only when SDIO IRQs are enabled. > Therefore, let's drop the redundant check of the internal > SDHCI_SDIO_IRQ_ENABLED flag and just re-enable the IRQs immediately. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/mmc/host/sdhci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index c1ebc26846db..2a9be044448a 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2161,8 +2161,7 @@ static void sdhci_ack_sdio_irq(struct mmc_host *mmc) > unsigned long flags; > > spin_lock_irqsave(&host->lock, flags); > - if (host->flags & SDHCI_SDIO_IRQ_ENABLED) > - sdhci_enable_sdio_irq_nolock(host, true); > + sdhci_enable_sdio_irq_nolock(host, true); > spin_unlock_irqrestore(&host->lock, flags); > }
FWIW:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
| |