Messages in this thread | | | Date | Thu, 5 Sep 2019 20:47:35 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 5.2 143/143] hsr: implement dellink to clean up resources |
| |
On Wed, Sep 04, 2019 at 05:20:40PM -0400, Sasha Levin wrote: > On Wed, Sep 04, 2019 at 07:54:46PM +0200, Greg Kroah-Hartman wrote: > > From: Cong Wang <xiyou.wangcong@gmail.com> > > > > commit b9a1e627405d68d475a3c1f35e685ccfb5bbe668 upstream. > > > > hsr_link_ops implements ->newlink() but not ->dellink(), > > which leads that resources not released after removing the device, > > particularly the entries in self_node_db and node_db. > > > > So add ->dellink() implementation to replace the priv_destructor. > > This also makes the code slightly easier to understand. > > > > Reported-by: syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com > > Cc: Arvid Brodin <arvid.brodin@alten.se> > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > Signed-off-by: David S. Miller <davem@davemloft.net> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > If the airport gods cooperate, I'm going to queue: > > edf070a0fb45a ("hsr: fix a NULL pointer deref in hsr_dev_xmit()") > 311633b604063 ("hsr: switch ->dellink() to ->ndo_uninit()") > > as fixes for this commit.
Ugh, sorry about that, I need to fix up my scripts :(
greg k-h
| |