Messages in this thread | | | From | "Alastair D'Silva" <> | Date | Wed, 04 Sep 2019 14:11:17 +1000 | Subject | RE: [PATCH v2 4/6] powerpc: Chunk calls to flush_dcache_range in arch_*_memory |
| |
On Tue, 2019-09-03 at 08:51 +0200, Christophe Leroy wrote: <snip>
> > > This piece of code looks pretty similar to the one before. Can we > > > refactor into a small helper ? > > > > > > > Not much point, it's removed in a subsequent patch. > > > > But you tell me that you leave to people the opportunity to not > apply > that subsequent patch, and that's the reason you didn't put that > patch > before this one. In that case adding a helper is worth it. > > Christophe
I factored it out anyway, since it made the code much nicer to read.
-- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819
| |