Messages in this thread | | | Subject | Re: [PATCH 0/8] tools-power-x86-intel-speed-select: Fixes and updates for output | From | Srinivas Pandruvada <> | Date | Wed, 04 Sep 2019 13:06:29 -0700 |
| |
On Tue, 2019-09-03 at 11:37 -0400, Prarit Bhargava wrote: > Some general fixes and updates for intel-speed-select. Fixes include > some > typos as well as an off-by-one cpu count reporting error. Updates > for the > output are > > - switching to MHz as a standard > - reporting CPU frequencies instead of ratios as a standard > - viewing a human-readable CPU list. > - avoiding reporting "0|1" as success|fail as these can be confusing > for a > user. Series looks fine, except 8/8. So please submit v2. Better to resubmit as a series as v2, unless Andy has other preference.
Thanks, Srinivas
> > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: David Arcari <darcari@redhat.com> > Cc: linux-kernel@vger.kernel.org > > Prarit Bhargava (8): > tools/power/x86/intel-speed-select: Fix package typo > tools/power/x86/intel-speed-select: Fix help option typo > tools/power/x86/intel-speed-select: Fix cpu-count output > tools/power/x86/intel-speed-select: Simplify output for turbo-freq > and > base-freq > tools/power/x86/intel-speed-select: Switch output to MHz > tools/power/x86/intel-speed-select: Change turbo ratio output to > maximum turbo frequency > tools/power/x86/intel-speed-select: Output human readable CPU list > tools/power/x86/intel-speed-select: Output success/failed for > command > output > > .../x86/intel-speed-select/isst-config.c | 4 +- > .../x86/intel-speed-select/isst-display.c | 116 ++++++++++++-- > ---- > 2 files changed, 83 insertions(+), 37 deletions(-) >
| |