Messages in this thread | | | From | Hayes Wang <> | Subject | RE: [PATCH net-next] r8152: modify rtl8152_set_speed function | Date | Tue, 3 Sep 2019 06:36:53 +0000 |
| |
Heiner Kallweit [mailto:hkallweit1@gmail.com] > Sent: Tuesday, September 03, 2019 2:14 PM [...] > >> Seeing all this code it might be a good idea to switch this driver > >> to phylib, similar to what I did with r8169 some time ago. > > > > It is too complex to be completed for me at the moment. > > If this patch is unacceptable, I would submit other > > patches first. Thanks. > > > My remark isn't directly related to your patch and wasn't > meant as an immediate ToDo. It's just a hint, because I think > using phylib could help to significantly simplify the driver.
I would schedule this in my work. Maybe I finish submitting the other patches later.
Besides, I have a question. I think I don't need rtl8152_set_speed() if I implement phylib. However, I need to record some information according to the settings of speed. For now, I do it in rtl8152_set_speed(). Do you have any idea about how I should do it with phylib without rtl8152_set_speed()?
Best Regards, Hayes
| |