Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 3 Sep 2019 09:43:03 +0200 | Subject | Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak |
| |
On Tue, Sep 3, 2019 at 12:34 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Mon, Sep 02, 2019 at 11:19:58PM +0200, Rafael J. Wysocki wrote: > > On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang <wenwen@cs.uga.edu> wrote: > > > > > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > > > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, > > > it is not deallocated if acpi_pci_irq_valid() returns false, leading to a > > > memory leak. To fix this issue, free 'entry' before returning 0. > > > > > > Fixes: e237a5518425 ("x86/ACPI/PCI: Recognize that Interrupt Line 255 means > > > "not connected"") > > > > > > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> > > > > Bjorn, any more comments? > > Nope, looks fine to me.
Thanks, queuing it up for v5.4 then.
| |