Messages in this thread | | | Subject | Re: [RFC PATCH] scripts: Fix coccicheck failed | From | Yuehaibing <> | Date | Sun, 29 Sep 2019 10:04:57 +0800 |
| |
On 2019/9/28 20:43, Julia Lawall wrote: > > > On Sat, 28 Sep 2019, YueHaibing wrote: > >> Run make coccicheck, I got this: >> >> spatch -D patch --no-show-diff --very-quiet --cocci-file >> ./scripts/coccinelle/misc/add_namespace.cocci --dir . >> -I ./arch/x86/include -I ./arch/x86/include/generated >> -I ./include -I ./arch/x86/include/uapi >> -I ./arch/x86/include/generated/uapi -I ./include/uapi >> -I ./include/generated/uapi --include ./include/linux/kconfig.h >> --jobs 192 --chunksize 1 >> >> virtual rule patch not supported >> coccicheck failed >> >> It seems add_namespace.cocci cannot be called in coccicheck. > > Could you explain the issue better? Does the current state cause make > coccicheck to fail? Or is it just silently not being called?
Yes, it cause make coccicheck failed like this:
... ./drivers/xen/xenbus/xenbus_comms.c:290:2-8: preceding lock on line 243 ./fs/fuse/dev.c:1227:2-8: preceding lock on line 1206 ./fs/fuse/dev.c:1232:3-9: preceding lock on line 1206 coccicheck failed make[1]: *** [coccicheck] Error 255 make: *** [sub-make] Error 2
> > thanks, > julia > >> >> Fixes: eb8305aecb95 ("scripts: Coccinelle script for namespace dependencies.") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> scripts/{coccinelle/misc => }/add_namespace.cocci | 0 >> scripts/nsdeps | 2 +- >> 2 files changed, 1 insertion(+), 1 deletion(-) >> rename scripts/{coccinelle/misc => }/add_namespace.cocci (100%) >> >> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/add_namespace.cocci >> similarity index 100% >> rename from scripts/coccinelle/misc/add_namespace.cocci >> rename to scripts/add_namespace.cocci >> diff --git a/scripts/nsdeps b/scripts/nsdeps >> index ac2b6031dd13..0f743b76e501 100644 >> --- a/scripts/nsdeps >> +++ b/scripts/nsdeps >> @@ -23,7 +23,7 @@ fi >> >> generate_deps_for_ns() { >> $SPATCH --very-quiet --in-place --sp-file \ >> - $srctree/scripts/coccinelle/misc/add_namespace.cocci -D ns=$1 $2 >> + $srctree/scripts/add_namespace.cocci -D ns=$1 $2 >> } >> >> generate_deps() { >> -- >> 2.20.1 >> >> >> > > . >
| |