lkml.org 
[lkml]   [2019]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 2/2] net: phy: mscc-miim: Move the setting of mii_bus structure members in mscc_miim_probe()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 27 Sep 2019 09:30:14 +0200

    Move the modification of some members in the data structure “mii_bus”
    for the local variable “bus” directly before the call of
    the function “of_mdiobus_register” so that this change will be performed
    only after previous resource allocations succeeded.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---

    v2:
    This suggestion was repeated based on the change for the previous update step.


    drivers/net/phy/mdio-mscc-miim.c | 13 ++++++-------
    1 file changed, 6 insertions(+), 7 deletions(-)

    diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c
    index aabb13982251..a270f83bb207 100644
    --- a/drivers/net/phy/mdio-mscc-miim.c
    +++ b/drivers/net/phy/mdio-mscc-miim.c
    @@ -124,13 +124,6 @@ static int mscc_miim_probe(struct platform_device *pdev)
    if (!bus)
    return -ENOMEM;

    - bus->name = "mscc_miim";
    - bus->read = mscc_miim_read;
    - bus->write = mscc_miim_write;
    - bus->reset = mscc_miim_reset;
    - snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev));
    - bus->parent = &pdev->dev;
    -
    dev = bus->priv;
    dev->regs = devm_platform_ioremap_resource(pdev, 0);
    if (IS_ERR(dev->regs)) {
    @@ -147,6 +140,12 @@ static int mscc_miim_probe(struct platform_device *pdev)
    }
    }

    + bus->name = "mscc_miim";
    + bus->read = mscc_miim_read;
    + bus->write = mscc_miim_write;
    + bus->reset = mscc_miim_reset;
    + snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(&pdev->dev));
    + bus->parent = &pdev->dev;
    ret = of_mdiobus_register(bus, pdev->dev.of_node);
    if (ret < 0) {
    dev_err(&pdev->dev, "Cannot register MDIO bus (%d)\n", ret);
    --
    2.23.0
    \
     
     \ /
      Last update: 2019-09-27 10:19    [W:4.501 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site