Messages in this thread | | | Subject | Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld | From | Vincenzo Frascino <> | Date | Thu, 26 Sep 2019 22:17:30 +0100 |
| |
On 9/26/19 4:59 PM, Catalin Marinas wrote: > On Thu, Sep 26, 2019 at 02:38:03PM +0100, Vincenzo Frascino wrote: >> arch/arm64/kernel/vdso32/Makefile | 9 +++++++++ > > Could you please also remove the unnecessary gcc-goto.sh check in this > file? We don't use jump labels in the vdso (can't run-time patch them). > I found it while forcing COMPATCC=clang with my additional diff and I > get the warning on 'make clean'. >
I will do it in a separate cleanup patch, I want to keep this only for the error reported by Will.
> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 22f0d31ea528..038357a1e835 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -40,9 +38,6 @@ VDSO_CAFLAGS += $(call cc32-option,-fno-PIE) > ifdef CONFIG_DEBUG_INFO > VDSO_CAFLAGS += -g > endif > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(COMPATCC)), y) > -VDSO_CAFLAGS += -DCC_HAVE_ASM_GOTO > -endif > > # From arm Makefile > VDSO_CAFLAGS += $(call cc32-option,-fno-dwarf2-cfi-asm) >
-- Regards, Vincenzo
| |