Messages in this thread | | | Subject | Re: [PATCH] hv_balloon: Add the support of hibernation | From | David Hildenbrand <> | Date | Thu, 26 Sep 2019 09:19:49 +0200 |
| |
On 25.09.19 22:03, Dexuan Cui wrote: >> From: linux-hyperv-owner@vger.kernel.org >> [... snipped ...] >>> Anyhow, just some comments from my side :) I can see how Windows Server >>> worked around that issue right now by just XOR'ing both features. >>> >>> David / dhildenb >> >> Thanks for sharing your thoughts! >> >> -- Dexuan > > Hi David, > If my explanation sounds good to you, can I have an Acked-by from you? >
I do ACK the approach but not the patch in it's current state. I don't like the ifdefs - once you can get rid of the ifdefery - e.g., after the prerequisite is upstream - you can add my
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
| |