Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 26 Sep 2019 08:52:48 +0200 | Subject | Re: [PATCH 1/2] spi: Add call to spi_slave_abort() function when spidev driver is released |
| |
Hi Lukasz,
On Thu, Sep 26, 2019 at 3:33 AM Lukasz Majewski <lukma@denx.de> wrote: > This change is necessary for spidev devices (e.g. /dev/spidev3.0) working > in the slave mode (like NXP's dspi driver for Vybrid SoC). > > When SPI HW works in this mode - the master is responsible for providing > CS and CLK signals. However, when some fault happens - like for example > distortion on SPI lines - the SPI Linux driver needs a chance to recover > from this abnormal situation and prepare itself for next (correct) > transmission. > > This change doesn't pose any threat on drivers working in master mode as > spi_slave_abort() function checks if SPI slave mode is supported. > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
Thanks for your patch!
Yesterday I saw this appear on spi/for-next, but I couldn't find the email in my mbox. Today it has arrived. Looks like gmail had some troubles ("Delivered after 138401 seconds", ugh).
> --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -627,6 +627,7 @@ static int spidev_release(struct inode *inode, struct file *filp) > if (dofree) > kfree(spidev); > } > + spi_slave_abort(spidev->spi);
Looks good to me. Just wondering if this should be done for the last user only, i.e. in the "if" block above, like resetting speed_hz?
> mutex_unlock(&device_list_lock); > > return 0;
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |