lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller
    Date
    Hi Xingyu,

    Xingyu Chen <xingyu.chen@amlogic.com> writes:

    > The number of RESET registers and offset of RESET_LEVEL register for
    > Meson-A1 are different from previous SoCs, In order to describe these
    > differences, we introduce the struct meson_reset_param.
    >
    > Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
    > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
    > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

    Again, order here isn't quite right. Add the reviewed-by tags first,
    and the sender should be the last sign-off.

    Other than that, driver looks good.

    Reviewed-by: Kevin Hilman <khilman@baylibre.com>

    Kevin

    \
     
     \ /
      Last update: 2019-09-26 00:57    [W:3.395 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site