Messages in this thread | | | Date | Tue, 24 Sep 2019 10:53:32 -0700 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions |
| |
On Tue, Sep 24, 2019 at 01:53:07PM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> > +/* the CDCLK (CODECLKO) gate clock */ > > +#define CLK_I2S_CDCLK 0
> I do not find it more readable because of removal of indent > after define name. Also the description is not accurate - you > documented, not increased readability.
Yeah, I agree on both points. How about putting everything on one line more like:
#define CLK_I2S_CDCLK 0 /* the CDCLK (CODECLKO) gate clock */
instead?
Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. [unhandled content-type:application/pgp-signature] | |