lkml.org 
[lkml]   [2019]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: direct-io: Fixed a Documentation build warn
On Tue, Sep 24, 2019 at 05:49:25PM +0530, Madhuparna Bhowmik wrote:
> Adds the description about
> offset within the code.

Why?

> @@ -255,6 +254,7 @@ void dio_warn_stale_pagecache(struct file *filp)
> */
> static ssize_t dio_complete(struct dio *dio, ssize_t ret, unsigned int flags)
> {
> + /* offset: the byte offset in the file of the completed operation */
> loff_t offset = dio->iocb->ki_pos;
> ssize_t transferred = 0;
> int err;

This is not normal practice within the Linux kernel. I suggest reading
section 8 of Documentation/process/coding-style.rst

\
 
 \ /
  Last update: 2019-09-24 14:24    [W:0.047 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site