Messages in this thread | | | From | Adam Thomson <> | Subject | RE: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation | Date | Tue, 24 Sep 2019 09:23:32 +0000 |
| |
On 17 September 2019 13:43, Marco Felsch wrote:
> Add the documentation which describe the voltage selection gpio support. > This property can be applied to each subnode within the 'regulators' > node so each regulator can be configured differently. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt > b/Documentation/devicetree/bindings/mfd/da9062.txt > index edca653a5777..9d9820d8177d 100644 > --- a/Documentation/devicetree/bindings/mfd/da9062.txt > +++ b/Documentation/devicetree/bindings/mfd/da9062.txt > @@ -66,6 +66,15 @@ Sub-nodes: > details of individual regulator device can be found in: > Documentation/devicetree/bindings/regulator/regulator.txt > > + Optional regulator device-specific properties: > + - dlg,vsel-sense-gpios : The GPIO reference which should be used by the > + regulator to switch the voltage between active/suspend voltage settings. If > + the signal is active the active-settings are applied else the suspend > + settings are applied. Attention: Sharing the same gpio for other purposes > + or across multiple regulators is possible but the gpio settings must be the > + same. Also the gpio phandle must refer to to the dlg,da9062-gpio device > + other gpios are not allowed and make no sense. > +
Should we not use the binding names that are defined in 'gpio-regulator.yaml' as these seem to be generic and would probably serve the purpose here?
> - rtc : This node defines settings required for the Real-Time Clock associated > with the DA9062. There are currently no entries in this binding, however > compatible = "dlg,da9062-rtc" should be added if a node is created. > -- > 2.20.1
| |