Messages in this thread | | | Subject | Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node | From | Lucas Stach <> | Date | Mon, 23 Sep 2019 19:00:58 +0200 |
| |
Am Montag, den 23.09.2019, 13:12 -0300 schrieb Fabio Estevam: > Hi Laurentiu, > > On Mon, Sep 23, 2019 at 11:14 AM Laurentiu Palcu > <laurentiu.palcu@nxp.com> wrote: > > > + > > + dcss: dcss@0x32e00000 { > > Node names should be generic, so: > > dcss: display-controller@32e00000 > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "nxp,imx8mq-dcss"; > > + reg = <0x32e00000 0x2D000>, > > <0x32e2f000 0x1000>; > > 0x2d000 for consistency. > > > + interrupts = <6>, <8>, <9>; > > The interrupts are passed in the <GIC_SPI xxx IRQ_TYPE_LEVEL_HIGH> > format.
No, they are not. Those are imx-irqsteer IRQs, this controller has 0 irq cells, so the description in this patch is correct.
Regards, Lucas
| |