Messages in this thread | | | Date | Mon, 23 Sep 2019 18:45:50 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [RESEND PATCH] drm/panfrost: Reduce the amount of logs on deferred probe |
| |
On Thu, Sep 12, 2019 at 10:36:25AM +0100, Steven Price wrote: > On 09/09/2019 16:51, Krzysztof Kozlowski wrote: > > There is no point to print deferred probe (and its failures to get > > resources) as an error. > > > > In case of multiple probe tries this would pollute the dmesg. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Looks like a good idea, however from what I can tell you haven't > completely silenced the 'error' as the return from > panfrost_regulator_init() will be -EPROBE_DEFER causing another > dev_err() output: > > err = panfrost_regulator_init(pfdev); > if (err) { > dev_err(pfdev->dev, "regulator init failed %d\n", err); > goto err_out0; > } > > Can you fix that up as well? Or indeed drop it altogether since > panfrost_regulator_init() already outputs an appropriate message.
I'll drop this error message then. Thanks for feedback!
Best regards, Krzysztof
| |